Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iconv-lite to fix deprecation warning for Node v10 #8

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Update iconv-lite to fix deprecation warning for Node v10 #8

merged 1 commit into from
Aug 13, 2018

Conversation

MarkTiedemann
Copy link
Contributor 

(node:299) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:159:11)
    at new Buffer (buffer.js:174:3)
    at module.exports (/opt/atlassian/pipelines/agent/build/node_modules/whatwg-encoding/node_modules/iconv-lite/lib/extend-node.js:11:46)
    at Object.<anonymous> (/opt/atlassian/pipelines/agent/build/node_modules/whatwg-encoding/node_modules/iconv-lite/lib/index.js:143:29)

See: https://github.com/ashtuchkin/iconv-lite/blob/master/Changelog.md#0423--2018-05-07

@domenic domenic merged commit 292a227 into jsdom:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkTiedemann @domenic