Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esmock from 2.3.8 to 2.5.1 in /lambda #61

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 1, 2023

Bumps esmock from 2.3.8 to 2.5.1.

Release notes

Sourced from esmock's releases.

improve ts resolution

resolve existing ".ts" files, rather than ".js" files, when typescript is detected, thanks @​tpluscode

use initialize loader hook

esmock is updated to use the new "initialize" node loader hook https://nodejs.org/api/esm.html#initialize and, essentially, esmock no longer requires --loader=esmock when used with current releases of node

detect null and undefined loader-returned sources

Detects null AND undefined loader-returned source definitions

diff --git a/src/esmockLoader.js b/src/esmockLoader.js
index 69dedd4..e835ec3 100644
--- a/src/esmockLoader.js
+++ b/src/esmockLoader.js
@@ -145,7 +145,8 @@ const load = async (url, context, nextLoad) => {
       if (!/^(commonjs|module)$/.test(nextLoadRes.format))
         return nextLoad(url, context)


 const source = nextLoadRes.source === null





 // nextLoadRes.source sometimes 'undefined' and other times 'null' :(



 const source = nextLoadRes.source === null || nextLoadRes.source === undefined
   ? String(await fs.readFile(new URL(url)))
   : String(nextLoadRes.source)
 const hbang = (source.match(hashbangRe) || [])[0] || ''


node v20.6 solutions

node v20.6 caused some issues. The primary issue was that the newest import.meta.resolve defined by node has significantly and suddenly changed. The newer import.meta.resolve is less useful and no longer supports the parent param as in the call import.meta.resolve(moduleId, parent),

Changelog

Sourced from esmock's changelog.

changelog

... (truncated)

Commits
  • 0b8888d Merge pull request #243 from iambumblehead/add-workspace-tests
  • 9591b4f credit @​tpluscode
  • 11907e8 update CHANGELOG, increment version number
  • 029647f git add local/main-ts.ts
  • ecefd8d rename main.ts to main-ts.ts, so that resolver does not return main.js
  • ed4dcd5 added a local file test to workspaces-ts
  • 582b1bb remove esmock sketch file
  • e420957 fix workspaces-ts file arrangement
  • 8636624 update workspaces tests
  • 9d28c02 use separate js and ts workspaces
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [esmock](https://github.com/iambumblehead/esmock) from 2.3.8 to 2.5.1.
- [Release notes](https://github.com/iambumblehead/esmock/releases)
- [Changelog](https://github.com/iambumblehead/esmock/blob/main/CHANGELOG.md)
- [Commits](iambumblehead/esmock@v2.3.8...v2.5.1)

---
updated-dependencies:
- dependency-name: esmock
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 1, 2023
@jsetton jsetton closed this Nov 10, 2023
Copy link
Author

dependabot bot commented on behalf of github Nov 10, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@jsetton jsetton deleted the dependabot/npm_and_yarn/lambda/esmock-2.5.1 branch November 10, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant