Documenting tool integration #104
Conversation
docs/how_to_config.md
Outdated
| ``` | ||
|
|
||
| If you've already specified all the configuration options in a config file, | ||
| here is how to cite them in `.pre-commit-config.yaml`: | ||
|
|
||
| ```yaml | ||
| # Option 1: with native tool | ||
| - repo: https://github.com/jsh9/pydoclint | ||
| rev: <latest_tag> | ||
| hooks: | ||
| - id: pydoclint | ||
| args: | ||
| - "--config=pyproject.toml" |
There was a problem hiding this comment.
I'm not a total expert in specifying args in pre-commit. Do you think the "official" way is to include quotes (like in this line) or not?
There was a problem hiding this comment.
Quotes aren't necessary here cuz there's no special or reserved chars.
https://pre-commit.com/#passing-arguments-to-hooks
The official docs don't have quotes for args. I will remove the quotes here for consistency
There was a problem hiding this comment.
Committed, let me know if you like quoted style better 👌
|
@jsh9 could I bump on this? |
Hi @jamesbraza , I'm sorry I've been quite busy over the past few weeks. I'll take a look in the next few days. |
|
Hi @jamesbraza , I still haven't got a chance to work on it. I'll try to finish this within 1-2 weeks. |
There was a problem hiding this comment.
@jsh9 thanks for the great feedback, it's now ready for your review
Upstreams knowledge from #96
Resolves #101
pre-commit-config.yamlforflake8-plugin, with configsAlso documents how to configure
ruffcompatibility usingexternal