pref: read value only when assigning in parse

jshttp · Jan 31, 2022 · 009b3cb · 009b3cb
1 parent 04be428
commit 009b3cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,6 +1,7 @@
 unreleased
 ==========
 
+  * pref: read value only when assigning in parse
   * pref: remove unnecessary regexp in parse
 
 0.4.1 / 2020-04-21

diff --git a/index.js b/index.js
@@ -65,15 +65,16 @@ function parse(str, options) {
     }
 
     var key = pair.substring(0, index).trim()
-    var val = pair.substring(index + 1, pair.length).trim()
-
-    // quoted values
-    if ('"' == val[0]) {
-      val = val.slice(1, -1);
-    }
 
     // only assign once
     if (undefined == obj[key]) {
+      var val = pair.substring(index + 1, pair.length).trim()
+
+      // quoted values
+      if (val[0] === '"') {
+        val = val.slice(1, -1)
+      }
+
       obj[key] = tryDecode(val, dec);
     }
   }