perf: reduce overhead when no X-Forwarded-For header

jshttp · Sep 15, 2017 · ad1efea · ad1efea
1 parent bbdcf0b
commit ad1efea
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * perf: reduce overhead when no `X-Forwarded-For` header
+
 0.1.1 / 2017-09-10
 ==================
 

diff --git a/index.js b/index.js
@@ -34,14 +34,29 @@ function forwarded (req) {
   }
 
   // simple header parsing
-  var proxyAddrs = (req.headers['x-forwarded-for'] || '')
-    .trim()
-    .split(TOKEN_LIST_REGEXP)
-    .filter(Boolean)
-    .reverse()
+  var proxyAddrs = parse(req.headers['x-forwarded-for'] || '')
   var socketAddr = req.connection.remoteAddress
   var addrs = [socketAddr].concat(proxyAddrs)
 
   // return all addresses
   return addrs
 }
+
+/**
+ * Parse the X-Forwarded-For header.
+ *
+ * @param {string} header
+ * @private
+ */
+
+function parse (header) {
+  if (!header) {
+    return []
+  }
+
+  return header
+    .trim()
+    .split(TOKEN_LIST_REGEXP)
+    .filter(Boolean)
+    .reverse()
+}