Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Google Docs, Spreadsheets and Slides mime types #38

Closed
wants to merge 1 commit into from
Closed

Added Google Docs, Spreadsheets and Slides mime types #38

wants to merge 1 commit into from

Conversation

ronanww
Copy link
Contributor

@ronanww ronanww commented Jan 5, 2016

No description provided.

@ronanww ronanww force-pushed the chore/google-docs-mime-types branch from 7f3672c to 54b06f3 Compare January 5, 2016 15:05
@dougwilson
Copy link
Contributor

Hi! Thanks for your contribution, but you cannot edit the db.json file, as that is auto-generated only. If you can update your pull request according to the instructions at https://github.com/jshttp/mime-db#contributing that would be awesome :)

@dougwilson dougwilson self-assigned this Jan 5, 2016
@ronanww ronanww force-pushed the chore/google-docs-mime-types branch from 54b06f3 to 7bff053 Compare January 5, 2016 15:19
@ronanww
Copy link
Contributor Author

ronanww commented Jan 5, 2016

@dougwilson done 👍

@dougwilson
Copy link
Contributor

Thank you! Since they are not part of the IANA, do you have any links to where they are specified?

@ronanww ronanww force-pushed the chore/google-docs-mime-types branch from 7bff053 to 16ec07f Compare January 5, 2016 23:52
@ronanww
Copy link
Contributor Author

ronanww commented Jan 5, 2016

@dougwilson I added the sources to the json file, check them out

@dougwilson
Copy link
Contributor

Thanks! I don't see it mention those file extension anywhere, though. Can you add the links to where the file extension associations are as well?

@ronanww ronanww force-pushed the chore/google-docs-mime-types branch from 16ec07f to d7791d9 Compare January 6, 2016 00:06
@ronanww
Copy link
Contributor Author

ronanww commented Jan 6, 2016

@dougwilson I just added a second source

@dougwilson
Copy link
Contributor

Awesome, thank you so much! Will be merged soon!

@dougwilson dougwilson closed this in f890737 Jan 6, 2016
@risu729 risu729 mentioned this pull request Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dougwilson dougwilson

Labels
enhancement pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronanww @dougwilson