Refactor wrap function for better readability and efficiency #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary es initialization outside the condition. - Simplified the flow by checking �syncHooks.AsyncResource and unInAsyncScope in a more direct manner. - Enhanced clarity by removing redundant comments and streamlining the code structure. - Maintained the backporting of the AsyncResource.bind static method for compatibility.
wesleytodd
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Unless we are going to break compat with node <16 I am opposed to this change.
As I said in the other PR I reviewed this morning, we dont typically accept formatting changes like this. I made an exception to my opinion for that one because it was simple and did improve readability. This one is much more ambigous and looks like an unnecesssary change to me.
Could you open a separate PR just for the JSDoc improvement? And then if you are interested in pushing a real featre open a PR to remove the check on line 223 so that we just always initalize the async resource now that we dont support node <18?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
wrapfunction for better readability and efficiencyresinitialization outside the condition.asyncHooks.AsyncResourceandrunInAsyncScopein a more direct manner.AsyncResource.bindstatic method for compatibility.