Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation is incorrect #18

Closed
zavr-1 opened this issue Dec 13, 2019 · 1 comment
Closed

documentation is incorrect #18

zavr-1 opened this issue Dec 13, 2019 · 1 comment
Labels
docs

Comments

@zavr-1
Copy link

zavr-1 commented Dec 13, 2019

the status function will not throw on 306
@jonchurch
Copy link
Member

jonchurch commented Dec 17, 2019 •
edited
Loading

You are correct. I'm not sure what the preferred fix here would be, making it throw would be a breaking change.

It seems to have snuck in with the IANA codes. The other 3 sources do not recognize 306 as a valid status. IANA lists it because it is a reserved status, but is deprecated.

The docs are indeed inaccurate, though.

@jonchurch jonchurch mentioned this issue Dec 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dougwilson @jonchurch @zavr-1