Remove code 306

closes #18 closes #19
jshttp · Apr 17, 2020 · eab4c63 · eab4c63
1 parent 055ea4d
commit eab4c63
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 5 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -3,6 +3,7 @@ unreleased
 
   * Drop support for Node.js 0.6
   * Fix messaging casing of `418 I'm a Teapot`
+  * Remove code 306
   * Remove `status[code]` exports; use `status.message[code]`
   * Remove `status[msg]` exports; use `status.code[msg]`
   * Rename `425 Unordered Collection` to standard `425 Too Early`

diff --git a/README.md b/README.md
@@ -51,7 +51,7 @@ status(403) // => 'Forbibben'
 status('403') // => 'Forbibben'
 status('forbidden') // => 403
 status('Forbidden') // => 403
-status(306) // throws, as it's not supported by node.js
+status(306) // throws, as it's no longer supported by the HTTP spec
 ```
 
 ### status.codes

diff --git a/codes.json b/codes.json
@@ -19,7 +19,6 @@
   "303": "See Other",
   "304": "Not Modified",
   "305": "Use Proxy",
-  "306": "(Unused)",
   "307": "Temporary Redirect",
   "308": "Permanent Redirect",
   "400": "Bad Request",

diff --git a/scripts/fetch-iana.js b/scripts/fetch-iana.js
@@ -20,9 +20,17 @@ https.get(URL, { headers: HEADERS }, function onResponse (res) {
     rows.forEach(function (row) {
       var obj = row.reduce(reduceRows, {})
 
-      if (obj.description !== 'Unassigned') {
-        codes[obj.value] = obj.description
+      // skip unassigned codes
+      if (obj.description === 'Unassigned') {
+        return
       }
+
+      // skip retired 306 code
+      if (obj.value === '306') {
+        return
+      }
+
+      codes[obj.value] = obj.description
     })
 
     write(path.join(__dirname, '../src/iana.json'), codes)

diff --git a/src/iana.json b/src/iana.json
@@ -19,7 +19,6 @@
   "303": "See Other",
   "304": "Not Modified",
   "305": "Use Proxy",
-  "306": "(Unused)",
   "307": "Temporary Redirect",
   "308": "Permanent Redirect",
   "400": "Bad Request",

diff --git a/test/test.js b/test/test.js
@@ -45,6 +45,10 @@ describe('status', function () {
       assert.throws(status.bind(null, 299), /invalid status code/)
       assert.throws(status.bind(null, 310), /invalid status code/)
     })
+
+    it('should throw for discontinued status code', function () {
+      assert.throws(status.bind(null, 306), /invalid status code/)
+    })
   })
 
   describe('when given a string', function () {