Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple position in a workplace #18

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

mangkoran
Copy link
Contributor

This PR adds support for multiple position/team in one workplace. Could you please recheck the updated JSON schema? I am afraid I missed one or two 😅

Copy link
Owner

@jskherman jskherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your significant contribution again @mangkoran. I think we can merge this already once some small changes are done.

cv.typ.schema.json Outdated Show resolved Hide resolved
example.yml Outdated Show resolved Hide resolved
example.yml Outdated Show resolved Hide resolved
@mangkoran mangkoran force-pushed the workplace-multiple-position branch 2 times, most recently from 4de86ec to d914b0d Compare January 22, 2024 10:46
@mangkoran
Copy link
Contributor Author

@jskherman I have updated the PR. Could you please check it again? Thank you.

Anyway, actually I'd like to reorder the section so Work -> Education instead of Education -> Work (which I felt a bit weird since we have the example.yml and Typst output arranged differently 😅). What's you preference: should I just add the commit in this PR or create a separate PR?

example.yml Show resolved Hide resolved
@jskherman
Copy link
Owner

jskherman commented Jan 22, 2024

@jskherman I have updated the PR. Could you please check it again? Thank you.

Anyway, actually I'd like to reorder the section so Work -> Education instead of Education -> Work (which I felt a bit weird since we have the example.yml and Typst output arranged differently 😅). What's you preference: should I just add the commit in this PR or create a separate PR?

It could really go either way for me, but Work => Education makes more sense. You can just add it as a commit here.

Example took a lot of lines, making it hard for user to read the schema
We could replace it with description instead later
@mangkoran
Copy link
Contributor Author

Updated with work and education switched.

Copy link
Owner

@jskherman jskherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other edits you want to make before merging?

@mangkoran
Copy link
Contributor Author

I think that's all for now. Thank you for your help!

@jskherman jskherman merged commit b6ad662 into jskherman:main Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants