-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multiple position in a workplace #18
feat: allow multiple position in a workplace #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your significant contribution again @mangkoran. I think we can merge this already once some small changes are done.
4de86ec
to
d914b0d
Compare
@jskherman I have updated the PR. Could you please check it again? Thank you. Anyway, actually I'd like to reorder the section so Work -> Education instead of Education -> Work (which I felt a bit weird since we have the |
It could really go either way for me, but Work => Education makes more sense. You can just add it as a commit here. |
Example took a lot of lines, making it hard for user to read the schema
We could replace it with description instead later
d914b0d
to
801a82b
Compare
Updated with work and education switched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other edits you want to make before merging?
I think that's all for now. Thank you for your help! |
This PR adds support for multiple position/team in one workplace. Could you please recheck the updated JSON schema? I am afraid I missed one or two 😅