Add test.statistic and test.type argument to getAnova() inside of getCoefficients() #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #305 but only for the specific case where all submodels are of class
lmerMod
.The
coefs()
function includes argumentstest.statistic
andtest.type
. But currently, those two arguments are not doing anything. They are intended to be arguments tocar::Anova()
, passed viagetAnova()
, but they are not passed all the way through togetAnova()
. As a result,car::Anova()
never "sees" them, and changing them has no effect, even if invalid values are input.The small correction I made here to the
getCoefficients()
function passes the user-specified arguments togetAnova()
, but only whenall(class(model) %in% c("lmerMod"))
is true. Therefore it has the desired result forlmer
models but does nothing otherwise. I would recommend noting that in the documentation ofcoefs
: specifying thattest.statistic
andtest.type
arguments will only have an effect if the models arelmerMod
.Thanks for your great package and thanks for your attention to this PR!