Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test.statistic and test.type argument to getAnova() inside of getCoefficients() #316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qdread
Copy link

@qdread qdread commented Dec 11, 2024

This PR addresses issue #305 but only for the specific case where all submodels are of class lmerMod.

The coefs() function includes arguments test.statistic and test.type. But currently, those two arguments are not doing anything. They are intended to be arguments to car::Anova(), passed via getAnova(), but they are not passed all the way through to getAnova(). As a result, car::Anova() never "sees" them, and changing them has no effect, even if invalid values are input.

The small correction I made here to the getCoefficients() function passes the user-specified arguments to getAnova(), but only when all(class(model) %in% c("lmerMod")) is true. Therefore it has the desired result for lmer models but does nothing otherwise. I would recommend noting that in the documentation of coefs: specifying that test.statistic and test.type arguments will only have an effect if the models are lmerMod.

Thanks for your great package and thanks for your attention to this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant