Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort issues by package name #81

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Sort issues by package name #81

merged 2 commits into from
Sep 3, 2024

Conversation

CvX
Copy link
Contributor

@CvX CvX commented Nov 4, 2022

Fixes a flaky test:

​ FAIL ​ tests/unlicensed-subdependency/test.js
 ✖ should be equal

  tests/unlicensed-subdependency/test.js
   5 | tap.equal(results.status, 1)
   6 |
>  7 | tap.equal(
     | ----^
   8 |   results.stdout.trim(),
   9 |   [
  10 |     'mit-licensed-depends-on-not-licensed@1.0.1',

  --- expected
  +++ actual
  @@ -1,15 +1,15 @@
  -mit-licensed-depends-on-not-licensed@1.0.1
  +not-licensed@1.0.0
     NOT APPROVED
  -  Terms: MIT
  -  Repository: jslicense/mit-licensed-depends-on-not-licensed.js
  +  Terms: Invalid license metadata
  +  Repository: jslicense/not-licensed.js
     Homepage: None listed
     Author: Kyle E. Mitchell <kyle@kemitchell.com> (https://kemitchell.com/)
     Contributors: None listed

  -not-licensed@1.0.0
  +mit-licensed-depends-on-not-licensed@1.0.1
     NOT APPROVED
  -  Terms: Invalid license metadata
  -  Repository: jslicense/not-licensed.js
  +  Terms: MIT
  +  Repository: jslicense/mit-licensed-depends-on-not-licensed.js
     Homepage: None listed
     Author: Kyle E. Mitchell <kyle@kemitchell.com> (https://kemitchell.com/)
     Contributors: None listed

  test: tests/unlicensed-subdependency/test.js
  stack: |
    Object.<anonymous> (tests/unlicensed-subdependency/test.js:7:5)
    Module.replacementCompile (node_modules/append-transform/index.js:60:13)
    Object.<anonymous> (node_modules/append-transform/index.js:64:4)

​ FAIL ​ tests/unlicensed-subdependency/test.js 1 failed of 2 16.992ms
 ✖ should be equal

  🌈 SUMMARY RESULTS 🌈

​ FAIL ​ tests/unlicensed-subdependency/test.js 1 failed of 2 16.992ms
 ✖ should be equal

Fixes a flaky test:

```
​ FAIL ​ tests/unlicensed-subdependency/test.js
 ✖ should be equal

  tests/unlicensed-subdependency/test.js
   5 | tap.equal(results.status, 1)
   6 |
>  7 | tap.equal(
     | ----^
   8 |   results.stdout.trim(),
   9 |   [
  10 |     'mit-licensed-depends-on-not-licensed@1.0.1',

  --- expected
  +++ actual
  @@ -1,15 +1,15 @@
  -mit-licensed-depends-on-not-licensed@1.0.1
  +not-licensed@1.0.0
     NOT APPROVED
  -  Terms: MIT
  -  Repository: jslicense/mit-licensed-depends-on-not-licensed.js
  +  Terms: Invalid license metadata
  +  Repository: jslicense/not-licensed.js
     Homepage: None listed
     Author: Kyle E. Mitchell <kyle@kemitchell.com> (https://kemitchell.com/)
     Contributors: None listed

  -not-licensed@1.0.0
  +mit-licensed-depends-on-not-licensed@1.0.1
     NOT APPROVED
  -  Terms: Invalid license metadata
  -  Repository: jslicense/not-licensed.js
  +  Terms: MIT
  +  Repository: jslicense/mit-licensed-depends-on-not-licensed.js
     Homepage: None listed
     Author: Kyle E. Mitchell <kyle@kemitchell.com> (https://kemitchell.com/)
     Contributors: None listed

  test: tests/unlicensed-subdependency/test.js
  stack: |
    Object.<anonymous> (tests/unlicensed-subdependency/test.js:7:5)
    Module.replacementCompile (node_modules/append-transform/index.js:60:13)
    Object.<anonymous> (node_modules/append-transform/index.js:64:4)

​ FAIL ​ tests/unlicensed-subdependency/test.js 1 failed of 2 16.992ms
 ✖ should be equal

  🌈 SUMMARY RESULTS 🌈

​ FAIL ​ tests/unlicensed-subdependency/test.js 1 failed of 2 16.992ms
 ✖ should be equal
```
@kemitchell
Copy link
Member

@CvX, please forgive me! I forgot about this PR, ran into the same test failure, and "fixed it" by fixing the test in 365c3a9.

I don't think we've made any claims about the order of results yet, and certainly not in SemVer terms. Sorting strikes me as a good idea.

@kemitchell kemitchell merged commit 7b08a0c into jslicense:main Sep 3, 2024
11 checks passed
@kemitchell
Copy link
Member

Published in 11.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants