Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Version 11 #96

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Prepare Version 11 #96

merged 6 commits into from
Sep 3, 2024

Conversation

kemitchell
Copy link
Member

@ljharb, I have got a bit lost in all your modular Actions CI configuration. Could I ask you to go in and correct my adding ls-engines to CI, or confirm that I managed to do it right?

I see there's an "engines" job that comes from all your configuration. But I also see that's running npx ls-engines --production false. We rather want to check production deps, ignoring dev deps and peer deps, on behalf of users.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kemitchell
Copy link
Member Author

I see how postlint would work, and I'll push that in a second. I do feel the scripts are becoming something of a rat's nest. I'd rather be giving scripts meaningful names and defining execution elsewhere. But I understand you've put substantial time into all the Actions configs. You maintain a lot. Not asking to make this the exception.

@kemitchell kemitchell merged commit 65a19dd into main Sep 3, 2024
22 checks passed
@kemitchell kemitchell deleted the version-11 branch September 3, 2024 04:42
@kemitchell
Copy link
Member Author

Released as 11.0.0.

@ljharb
Copy link
Member

ljharb commented Sep 3, 2024

It's totally fine to add an exception, but the convention of npm test running everything locally requires a maze of scripts, and "efficient CI" requires only running tests in the matrix and running everything else once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants