Fix incorrect transpositions for LGPL and other inputs containing "GPL" or "General Public License" #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of incorrect transpositions related to "GPL" or "General Public License".
Firstly, it corrects a mistake in the existing transpositions where LGPL patterns are explicitly mapped to GPL, not LGPL:
Second, it adds additional transpositions to try and match specific version numbers of GPL/LGPL.
Finally, and perhaps most importantly, this PR applies a sort to the transpositions such that we'll try replacing longer substrings before shorter substrings. This is to avoid a common substring such as "GENERAL PUBLIC LICENSE" from matching to "LESSER GENERAL PUBLIC LICENSE" before a more accurate match simply because of the order they were defined in the array.