Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove short-hand interfaces for TId is int #1093

Merged
merged 7 commits into from
Oct 28, 2021
Merged

Conversation

bart-degreed
Copy link
Contributor

@bart-degreed bart-degreed commented Oct 8, 2021

Closes #1044.

QUALITY CHECKLIST

@bart-degreed bart-degreed marked this pull request as draft October 8, 2021 15:22
@bart-degreed bart-degreed force-pushed the remove-int-generics branch 2 times, most recently from d1e299a to 964c332 Compare October 8, 2021 16:08
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1093 (e55ec82) into master (758a191) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage   88.18%   88.21%   +0.02%     
==========================================
  Files         256      256              
  Lines        6990     6931      -59     
==========================================
- Hits         6164     6114      -50     
+ Misses        826      817       -9     
Impacted Files Coverage Δ
...iDotNetCoreExample/Controllers/PeopleController.cs 0.00% <ø> (ø)
...ApiDotNetCoreExample/Controllers/TagsController.cs 0.00% <ø> (ø)
...tNetCoreExample/Controllers/TodoItemsController.cs 0.00% <ø> (ø)
...otNetCoreExample/Definitions/TodoItemDefinition.cs 0.00% <ø> (ø)
...Examples/JsonApiDotNetCoreExample/Models/Person.cs 0.00% <ø> (ø)
...rc/Examples/JsonApiDotNetCoreExample/Models/Tag.cs 0.00% <ø> (ø)
...amples/JsonApiDotNetCoreExample/Models/TodoItem.cs 0.00% <ø> (ø)
...ContextExample/Controllers/ResourceAsController.cs 100.00% <ø> (ø)
...ContextExample/Controllers/ResourceBsController.cs 100.00% <ø> (ø)
...Examples/MultiDbContextExample/Models/ResourceA.cs 100.00% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758a191...e55ec82. Read the comment docs.

bart-degreed pushed a commit that referenced this pull request Oct 18, 2021
@bart-degreed bart-degreed marked this pull request as ready for review October 27, 2021 14:42
@maurei maurei merged commit 4a2abe9 into master Oct 28, 2021
@maurei maurei deleted the remove-int-generics branch October 28, 2021 08:29
bart-degreed pushed a commit that referenced this pull request Dec 3, 2021
* Removed single-parameter controllers

* Removed base class: I can't think of a reason why we should have an intermediate base class for these tests

* Removed single-parameter resource services

* Removed single-parameter resource repositories

* Removed single-parameter resource definitions

* Removed non-generic Identifiable and throw for resource classes that only implement IIdentifiable (without ID) when building the resource graph

* Updated documentation
bart-degreed pushed a commit that referenced this pull request Dec 3, 2021
* Removed single-parameter controllers

* Removed base class: I can't think of a reason why we should have an intermediate base class for these tests

* Removed single-parameter resource services

* Removed single-parameter resource repositories

* Removed single-parameter resource definitions

* Removed non-generic Identifiable and throw for resource classes that only implement IIdentifiable (without ID) when building the resource graph

* Updated documentation
bart-degreed pushed a commit that referenced this pull request Dec 3, 2021
* Removed single-parameter controllers

* Removed base class: I can't think of a reason why we should have an intermediate base class for these tests

* Removed single-parameter resource services

* Removed single-parameter resource repositories

* Removed single-parameter resource definitions

* Removed non-generic Identifiable and throw for resource classes that only implement IIdentifiable (without ID) when building the resource graph

* Updated documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove int-based shortcuts in generic signatures
2 participants