Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistent calchash for utf8 tag #296

Closed
wants to merge 1 commit into from
Closed

fix inconsistent calchash for utf8 tag #296

wants to merge 1 commit into from

Conversation

ceshihao
Copy link
Contributor

fix #286

It is because the different ways to calculate hash between readFieldHash and calcHash (by byte or rune)

func (iter *Iterator) readFieldHash() int64 {

func calcHash(str string, caseSensitive bool) int64 {

@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #296 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
- Coverage    81.5%   81.49%   -0.01%     
==========================================
  Files          41       41              
  Lines        5000     4999       -1     
==========================================
- Hits         4075     4074       -1     
  Misses        804      804              
  Partials      121      121
Impacted Files Coverage Δ
iter_object.go 66.47% <100%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a568c...ff409cd. Read the comment docs.

@taowen
Copy link
Contributor

taowen commented Aug 6, 2018

thank you

@taowen taowen closed this Aug 6, 2018
@ceshihao ceshihao deleted the fix_utf8_tag_calchash branch August 6, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json 标签为中文时解析失败,但是“encoding/json”是支持的
2 participants