Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use the tolerateEmptyArrayExtension if no custom unmarshaller is used #702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paul-conneqtech
Copy link

I ran into an issue when trying to custom unmarshal a struct when the fuzzy decoder is registered.

Scenario is that an element in the json can either be a struct/string/int or a slice to that. To solve that I use a custom struct with an custom unmarshaller.

However if the json I want to decode starts with [ the tolerateEmptyArrayExtension replaces it completly with {}. Even if the array is not empty, as it name of this extension suggests.

To not break functionality I did not change the logic of the decoder itself. Instead I only activate the decoder when the target does not implement the json.Unmarshaler interface. When a struct implements json.Unmarshaler it should handle the possible empty array syntax itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant