-
-
Notifications
You must be signed in to change notification settings - Fork 215
Change http links to https for links to json-schema.org in documentation #355
Conversation
Deploy preview for condescending-hopper-c3ed30 ready! Built with commit 89610e9 https://deploy-preview-355--condescending-hopper-c3ed30.netlify.app |
@ben-rubin Thank you for your well-intended PR. All of the HTML and TXT files are generated from the XML files, which are not in this repo. In the You're welcome to modify this PR, but a blanket search/replace isn't going to be what we need here. It's going to be a manual case by case checking job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comments.
@Relequestual, thank you for the all of the info. Certainly, I will go back over it with your advice in mind. |
Apologies for the INSANE long delay. This simply hasn't been on my radar. I'm trying to do better. |
@ben-rubin if you can enable maintainers to make changes, I can push and resolve the merge conflicts, as I've rebased. I'll give you 1 week, after which I'll push this change via another PR and close this one. You'll still be credited for the commit =] |
Please leave this PR open as GitHub are investigating a UI issue. |
Hi, my apologies for the delay. It seems that I've accidentally deleted my fork. I can recreate the pr from a new fork or just go ahead and make the change as you see fit. |
This may actually explain the UI issue I was seeing. I'll see what GitHub support say when they pick this up. In terms of the PR, let's see who gets to it first? =] |
New PR opened here :) #425 |
Closed in favour of #425 |
No description provided.