Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Change http links to https for links to json-schema.org in documentation #355

Closed
wants to merge 1 commit into from
Closed

Change http links to https for links to json-schema.org in documentation #355

wants to merge 1 commit into from

Conversation

ben-rubin
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 24, 2020

Deploy preview for condescending-hopper-c3ed30 ready!

Built with commit 89610e9

https://deploy-preview-355--condescending-hopper-c3ed30.netlify.app

@Relequestual
Copy link
Member

@ben-rubin Thank you for your well-intended PR.
Unfortunatly, we can't merge as-is, as there are a few constraints around the changes you've made.

All of the HTML and TXT files are generated from the XML files, which are not in this repo.
Old drafts are fixed and cannot be changed.
The URLs used in $schema and $id are fixed, specifically http, and cannot be changed.
This applies for draft-07 and prior; the meta-schema URIs are http, not https.

In the 2019-09 draft, we forgot to update the meta-schema URI to be https, however in the meta-schema itself, it is https://json-schema.org/draft/2019-09/schema.

You're welcome to modify this PR, but a blanket search/replace isn't going to be what we need here. It's going to be a manual case by case checking job.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comments.

@ben-rubin
Copy link
Contributor Author

@Relequestual, thank you for the all of the info. Certainly, I will go back over it with your advice in mind.

@ben-rubin ben-rubin changed the title Change http://json-schema.org to https://json-schema.org Change http links to https for links to json-schema.org in documentation Nov 15, 2020
@Relequestual
Copy link
Member

Apologies for the INSANE long delay. This simply hasn't been on my radar. I'm trying to do better.

@Relequestual
Copy link
Member

@ben-rubin if you can enable maintainers to make changes, I can push and resolve the merge conflicts, as I've rebased.

I'll give you 1 week, after which I'll push this change via another PR and close this one.

You'll still be credited for the commit =]

@Relequestual
Copy link
Member

Please leave this PR open as GitHub are investigating a UI issue.

@ben-rubin
Copy link
Contributor Author

Hi, my apologies for the delay. It seems that I've accidentally deleted my fork. I can recreate the pr from a new fork or just go ahead and make the change as you see fit.

@Relequestual
Copy link
Member

Hi, my apologies for the delay. It seems that I've accidentally deleted my fork. I can recreate the pr from a new fork or just go ahead and make the change as you see fit.

This may actually explain the UI issue I was seeing. I'll see what GitHub support say when they pick this up.

In terms of the PR, let's see who gets to it first? =]

@ben-rubin
Copy link
Contributor Author

This may actually explain the UI issue I was seeing. I'll see what GitHub support say when they pick this up.

In terms of the PR, let's see who gets to it first? =]

New PR opened here :) #425

@Relequestual
Copy link
Member

Closed in favour of #425

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants