Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bookending requirement for dynamicRef #1139

Merged

Conversation

jdesrosiers
Copy link
Member

Resolves #1064

Discussion about changes to $dynamicRef behavior are still on going, but I want to capture the part that we did get consensus on, which is to remove the bookending requirement.

@jdesrosiers
Copy link
Member Author

Force pushed to fix conflicts caused by merging IRI changes.

jsonschema-core.xml Show resolved Hide resolved
jsonschema-core.xml Show resolved Hide resolved
jsonschema-core.xml Show resolved Hide resolved
@Relequestual Relequestual added this to the draft-next milestone Nov 23, 2021
@Relequestual Relequestual merged commit c947b03 into json-schema-org:draft-next Dec 3, 2021
jdesrosiers added a commit to jdesrosiers/json-schema-spec that referenced this pull request Jun 30, 2022
* Remove bookending requirement for dynamicRef

* Add $dynamicRef changes to change log
jdesrosiers added a commit to jdesrosiers/json-schema-spec that referenced this pull request Jun 30, 2022
* Remove bookending requirement for dynamicRef

* Add $dynamicRef changes to change log
jdesrosiers added a commit that referenced this pull request Jul 8, 2022
* Remove bookending requirement for dynamicRef

* Add $dynamicRef changes to change log
@jdesrosiers jdesrosiers deleted the dynamicref-no-bookend branch July 8, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove $dynamicRef bookending requirement
3 participants