Add propertyDependencies keyword #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s/dependentProperties/propertyDependencies/ in commit message |
jdesrosiers
force-pushed
the
dependentproperties
branch
from
45ca597
to
9ab9e28
Compare
12 tasks
6 tasks
7 tasks
karenetheridge
approved these changes
Feb 4, 2022
jdesrosiers
force-pushed
the
dependentproperties
branch
from
9ab9e28
to
074450a
Compare
|
(Force pushed to rebase and resolve conflicts) |
Relequestual
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
I can see that you've tried to match the language from dependentSchemas, but I feel that's also poorly defined.
I think we need to do a lot of review to make sure application keywords talk about application and not validation so much, but that's outside the scope of this Issue and PR!
ChALkeR
added a commit
to ExodusMovement/schemasafe
that referenced
this pull request
Oct 6, 2022
For now, causes an uncertainty from removeAdditional / useDefaults, but that could be resolved/optimized in some certain situations later. Refs: json-schema-org/json-schema-spec#1082 Refs: json-schema-org/json-schema-spec#1143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1082
I tried to match the language used for
dependentSchemasas much as possible given the similarity between the two keywords.