Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refer to core regex section from patternProperties and pattern #1547

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gregsdennis
Copy link
Member

What kind of change does this PR introduce?

Clarification

Issue & Discussion References

Summary

Updates the patternProperties (Core) and pattern (Validation) sections to point back to the Core section about regex.

Does this PR introduce a breaking change?

No

@gregsdennis gregsdennis added this to the stable-release milestone Oct 20, 2024
@gregsdennis gregsdennis requested a review from a team October 20, 2024 06:59
@gregsdennis gregsdennis self-assigned this Oct 20, 2024
@gregsdennis gregsdennis force-pushed the gregsdennis/regex-clarification branch from 037ad82 to a074aad Compare October 22, 2024 08:11
@gregsdennis gregsdennis marked this pull request as ready for review October 22, 2024 08:18
@gregsdennis gregsdennis force-pushed the gregsdennis/regex-clarification branch from f582969 to e49500d Compare November 8, 2024 23:10
@jdesrosiers
Copy link
Member

The link checker fails for this because it references the built result. I'm not sure what the best fix will be for this. Maybe there's some config in remark-validate-links that we can use that will fix the problem. If not, we can have links point to .md, but transform them to .html as part of the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Pattern: clarification on whether leading and trailing delimiters are allowed or required
2 participants