Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: patternProperties raised errors when the pattern has slashes #194

Merged
merged 3 commits into from
Dec 3, 2015

Conversation

ribeiropaulor
Copy link
Contributor

Now the delimiter to evaluate the regex is chosen dynamically.

@bighappyface
Copy link
Collaborator

@ribeiropaulor please rebase on master. Thanks for adding the tests.

@ribeiropaulor
Copy link
Contributor Author

rebased!

$matches = array();
foreach ($patternProperties as $pregex => $schema) {
// Choose delimiter. Necessary for patterns like ^/ , otherwise you get error
foreach ($try as $delimiter) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$delimiter should be defined and defaulted to a sensible value before this loop. Otherwise, $delimiter is only defined per the loop and will be set the last value if nothing breaks the loop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@ribeiropaulor
Copy link
Contributor Author

should be good to merge

@bighappyface
Copy link
Collaborator

+1

bighappyface added a commit that referenced this pull request Dec 3, 2015
bugfix: patternProperties raised errors when the pattern has slashes
@bighappyface bighappyface merged commit 7c78776 into jsonrainbow:master Dec 3, 2015
@ribeiropaulor ribeiropaulor deleted the justinrainbow/master branch December 4, 2015 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants