-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close div tag in resume.hbs #16
base: master
Are you sure you want to change the base?
Close div tag in resume.hbs #16
Conversation
You should convert your indentation from tabs to spaces. |
@ishu3101 - the rest of the code uses tabs, so I thought it better to be consistent. |
I see that in the commit that you have made above, the git diff is showing extra tabs have been added before each line (as shown in the screenshot below) which means the alignment of the code is not write and what git diff is telling is that you have made changes to line 16 - 27 instead of just adding the closing div tag. |
I noticed that you have also removed the indentation of the closing body tag as well. |
to address jsonresume#16 (comment). Also re-added empty line between opening body tag and opening tag of #resume div.
Re-added, also added back the empty line directly after the opening body tag. |
Great. You should squash your commits into a single commit as it makes no sense to pollute the history with 3 commits of you just fixing things. A single commit of everything correct is the correct way to go. |
With indentation per discussion thread: jsonresume#16 Fixes: jsonresume#15
Fixes: #15