Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add full theme path when using local themes on export #689

Merged
merged 4 commits into from
Apr 20, 2022
Merged

fix: add full theme path when using local themes on export #689

merged 4 commits into from
Apr 20, 2022

Conversation

Nezteb
Copy link
Contributor

@Nezteb Nezteb commented Apr 10, 2022 •
edited

Addresses #685 and potentially #408

This was referenced Apr 10, 2022
Open
Closed
@Nezteb
Copy link
Contributor Author

Nezteb commented Apr 10, 2022

FYI @rbardini @antialias

@Nezteb Nezteb changed the title Add full theme path when using local themes on export fix: add full theme path when using local themes on export Apr 10, 2022
@Nezteb
Copy link
Contributor Author

Nezteb commented Apr 11, 2022

The lockfile changes are because I get this warning when running npm install:

npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

I'm on npm 8.1.0.

The husky folder is automatically added when I run npm install. If it shouldn't be there, I can add it to the .gitignore but for now I'm leaving it.

@rbardini
Copy link
Contributor

The husky folder is automatically added when I run npm install. If it shouldn't be there, I can add it to the .gitignore but for now I'm leaving it.

husky@7.0.0 makes .husky/.gitignore unnecessary, but upgrading Husky is beyond the scope of this PR 🙂

LGTM!

@Nezteb
Copy link
Contributor Author

Nezteb commented Apr 20, 2022

@rbardini Is there anything else that needs to be done to get this merged? 😄

@rbardini rbardini added the Fix label Apr 20, 2022
@rbardini rbardini linked an issue Apr 20, 2022 that may be closed by this pull request
Cloned themes as git submodules, installed them, but can't export as PDF? #685
Closed
@rbardini rbardini merged commit 21d15f6 into jsonresume:master Apr 20, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rbardini
Copy link
Contributor

@Nezteb sorry for the delay, it's merged now. Thanks for your contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbardini rbardini rbardini approved these changes

Assignees
No one assigned
Labels
Fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloned themes as git submodules, installed them, but can't export as PDF?
2 participants
@Nezteb @rbardini