major(theme): use jsonresume-theme-even by default #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll defer to @thomasdavis for this review and will make a note to check back in a few weeks. |
|
I think this is great and happy to merge. awesome work @rbardini |
|
@rbardini I've given you collaborator access so you can merge these when your happy |
|
Thanks, @thomasdavis! I'll fix conflicts and merge right away. |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonresume-theme-even is a flat theme based on jsonresume-theme-flat, compatible with the latest resume schema. It was forked to add support for projects (jsonresume/resume-schema#254) and fix vulnerability issues, as the original repository seems to be inactive. It is used by a few dependents and is the default theme of @rbardini/resume-cli package, whose changes I'm trying to incorporate back here via separate PRs. See a working example.
I've also removed all preinstalled themes but the default one. I believe the CLI should be lightweight and easy to maintain. You can check how many packages have been removed from the lockfile with this change. I plan to drop the Handlebars dependency from jsonresume-theme-even at some point, so even fewer dependencies would be installed.
Because replacing the default theme is a breaking change, it's a good opportunity to remove extra themes and reduce the package footprint.