-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: using node14 with type:module #434
base: master
Are you sure you want to change the base?
Conversation
@@ -6,7 +6,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
node: [10, 12, 14] | |||
node: [14.15.1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only one version is tested, a matrix is not needed. But it may still be useful to test in different Node.js versions.
Also, I believe 14
would use the latest 14 version, so we don't need to set the complete version. (same below and in .npmrc
)
@@ -3,8 +3,9 @@ | |||
"version": "0.0.0-development", | |||
"description": "The JSON Resume command line interface", | |||
"main": "index.js", | |||
"type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the published package.json once we compile the source with Babel? Not sure anyone is importing resume-cli, but still.
I believe this is not a breaking change if we merge #433 first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just keep the testing on multiple node versions for now, see how it goes with the babel PR.
setting this to "draft" because it appears that jest is still working on support for ES6 modules, and my attempts to get it working using experimental flags have so far been unsuccessful. relevant jest issue here: jestjs/jest#9430 |
No description provided.