Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #430

Merged
merged 11 commits into from
Oct 14, 2017
Merged

Update dependencies #430

merged 11 commits into from
Oct 14, 2017

Conversation

maxbeatty
Copy link
Member

@maxbeatty maxbeatty commented Oct 4, 2017 •
edited
Loading

@maxbeatty maxbeatty self-assigned this Oct 4, 2017
@maxbeatty
Copy link
Member Author

relaxing the Node Security PR check since there's no upstream fix :(

asilluron
asilluron approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@asilluron asilluron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asilluron
Copy link
Member

Linking the one issue node security flagged. It's not clear what module uses timespan (likely Joi?) but I know we're not using it directly to validate anything.

indexzero/TimeSpan.js#10

@maxbeatty
Copy link
Member Author

Path to vulnerability: good-loggly@3.1.0 > loggly@1.1.1 > timespan@2.3.0. Might be awhile before all 3 get bumped w/ fix.

@maxbeatty maxbeatty merged commit 5cfbf85 into master Oct 14, 2017
@maxbeatty maxbeatty deleted the updep-oct branch October 14, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asilluron asilluron asilluron approved these changes

@mathiasbynens mathiasbynens Awaiting requested review from mathiasbynens

Assignees

@maxbeatty maxbeatty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxbeatty @asilluron