Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: worker_threads #26

Merged
merged 12 commits into from
Aug 22, 2021
Merged

feat: worker_threads #26

merged 12 commits into from
Aug 22, 2021

Conversation

Mesteery
Copy link
Contributor

@Mesteery Mesteery commented Aug 21, 2021 •
edited
Loading

Fixes #8.

Except types, normally deno/worker_threads.ts is the same as src-browser/worker_threads.js.
For Deno, I can make a PR (in deno_std) for worker_threads, and when there is a release, replace the current code with an import?

@Mesteery Mesteery marked this pull request as draft August 21, 2021 23:29
guybedford
guybedford approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Very cool to see this this has been needed for a while and opens up a lot of scenarios thank you!

Did you PR the same implementation directly to Deno?

Happy to land in the mean time here as well certainly.

nodelibs/deno/worker_threads.ts Show resolved Hide resolved
nodelibs/deno/worker_threads.ts Outdated Show resolved Hide resolved
nodelibs/deno/worker_threads.ts Show resolved Hide resolved
Mesteery and others added 4 commits August 22, 2021 10:24
@Mesteery @guybedford
Update nodelibs/deno/worker_threads.ts
3dff715 
Co-authored-by: Guy Bedford <guybedford@gmail.com>
@Mesteery
fixup
80f2113
@Mesteery
fixup
7e5ee6d
@Mesteery
fixup
4573050
@Mesteery Mesteery marked this pull request as ready for review August 22, 2021 17:51
@Mesteery Mesteery requested a review from guybedford August 22, 2021 17:52
@guybedford guybedford merged commit 3aa0859 into jspm:main Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

worker_threads
2 participants
@Mesteery @guybedford