Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

add override for npm:bootstrap@4.0.0-beta #1059

Closed
wants to merge 1 commit into from
Closed

add override for npm:bootstrap@4.0.0-beta #1059

wants to merge 1 commit into from

Conversation

bbak
Copy link
Contributor

@bbak bbak commented Sep 6, 2017

Replace Tether with Popper.js, see bootstrap#22444

Copy link
Collaborator

@aluanhaddad aluanhaddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR.

There is actually already one open for bootstrap@4.0.0-beta but it needs some work.

The dependencies unfortunately need to be moved to peerDependencies

I tried this override locally, after changing them to peers, and found the same issues with popper.js as in the other, #1056.

A problem is that although popper.js is a well behaved package, only registering itself globally as a last resort, bootstrap is emphatically not. It requires that a global variable named Popper exist or it fails. To make matters worse, bootstrap depends on popper.js as a peerDependency causing pollution for all users of that package even if they are not using bootstrap. This may be something that we have to live with.

I believe that, unfortunately, the only way to get this working is to add an override that globalizes popper.js.

For more information, checkout the comments on #1056

@aluanhaddad
Copy link
Collaborator

It looks like the next beta release will include Popper.js in the bundle itself which will make this easier.

@bbak bbak closed this Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants