Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add internationalization (i.e. translations and more) support #3107

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions packages/jspsych/src/JsPsych.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ export class JsPsych {
// of jsPsych
webaudio_context: AudioContext = null;

/**
* the currently active locale (if specified)
*/
locale: string | undefined = undefined;

internal = {
/**
* this flag is used to determine whether we are in a scope where
Expand Down Expand Up @@ -117,10 +122,15 @@ export class JsPsych {
override_safe_mode: false,
case_sensitive_responses: false,
extensions: [],
translations: {},
locale: undefined,
fallback_locale: undefined,
...options,
};
this.opts = options;

this.locale = this.opts.locale;

autoBind(this); // so we can pass JsPsych methods as callbacks and `this` remains the JsPsych instance

this.webaudio_context =
Expand Down Expand Up @@ -379,6 +389,49 @@ export class JsPsych {
return this.timeline.allTimelineVariables();
}

setLocale(locale: string) {
this.locale = locale;
}

translate(key: string) {
// TODO: This should support string processing + maybe more i18n features

// First pass at translation using the current locale
const locale = this.locale;
if (locale) {
const translation = this.searchTranslation(locale, key);
if (translation !== undefined) {
return translation;
}
}
// Second pass using the fallback_locale
const fallbackLocale = this.opts.fallback_locale;
if (fallbackLocale) {
const translation = this.searchTranslation(fallbackLocale, key);
if (translation !== undefined) {
return translation;
}
}
// If nothing is found, default to return the original translation key
return key;
}

private searchTranslation(locale: string, key: string) {
// First search for translations on the trial itself
if (
this.current_trial.translations &&
locale in this.current_trial.translations &&
key in this.current_trial.translations[locale]
) {
return this.current_trial.translations[locale][key];
}
// Then search for global translations
if (locale in this.opts.translations && key in this.opts.translations?.[locale]) {
return this.opts.translations[locale][key];
}
return undefined;
}

addNodeToEndOfTimeline(new_timeline, preload_callback?) {
this.timeline.insert(new_timeline);
}
Expand Down
73 changes: 73 additions & 0 deletions packages/jspsych/tests/core/i18n.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
import htmlKeyboardResponse from "@jspsych/plugin-html-keyboard-response";
import { pressKey, startTimeline } from "@jspsych/test-utils";

import { initJsPsych } from "../../src";

describe("translations are correctly fetched", () => {
test("when drawing from the global translations", async () => {
const jsPsych = initJsPsych({
locale: "de",
translations: {
de: {
"Hello World!": "Hallo Welt!",
},
},
});
const { getHTML } = await startTimeline(
[
{
type: htmlKeyboardResponse,
stimulus: () => jsPsych.translate("Hello World!"),
on_finish: () => {
jsPsych.setLocale("en");
},
},
{
type: htmlKeyboardResponse,
stimulus: () => jsPsych.translate("Hello World!"),
},
],
jsPsych
);

expect(getHTML()).toMatch("Hallo Welt!");
pressKey("a");
expect(getHTML()).toMatch("Hello World!");
});

test("when drawing from trial-level translations", async () => {
const jsPsych = initJsPsych({
locale: "de",
});
const { getHTML } = await startTimeline(
[
{
type: htmlKeyboardResponse,
stimulus: () => jsPsych.translate("Hello World!"),
translations: {
de: {
"Hello World!": "Hallo Welt!",
},
},
on_finish: () => {
jsPsych.setLocale("en");
},
},
{
type: htmlKeyboardResponse,
stimulus: () => jsPsych.translate("Hello World!"),
translations: {
de: {
"Hello World!": "Hallo Welt!",
},
},
},
],
jsPsych
);

expect(getHTML()).toMatch("Hallo Welt!");
pressKey("a");
expect(getHTML()).toMatch("Hello World!");
});
});
Loading