Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jspsych-extension-mouse-tracking.html #3414

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

EitanHemed
Copy link
Contributor

The const start has been removed in the previous commit, and does not seem to be currently required to run the demo (i.e., the reference to it raises "Uncaught ReferenceError:".

The const `start` has been removed in the previous commit, and does not seem to be currently required to run the demo (i.e., the reference to it raises "Uncaught ReferenceError:".
Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 82ca149

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@jadeddelta jadeddelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @EitanHemed ! :) LGTM, just removed some additional code: the check for the jspsych object is only for online hosted examples but since these are locally hosted it is not necessary to have that check.

@jodeleeuw jodeleeuw merged commit 57c0da6 into jspsych:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants