Improve error message for missing type parameter #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodeleeuw
approved these changes
Jan 5, 2025
|
Thanks @rkilpadi! This isn't directed at anyone in particular: Curious that changesets bot didn't comment on this PR. Seeing if this comment will trigger it. |
🦋 Changeset detectedLatest commit: ff5f67b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@jodeleeuw We didn't approve the workflow runs on this PR – I didn't find the button here as well with GH's ✨ new merge experience ✨; had to go to the workflows list manually and approve the runs 🥴 From the GH feedback discussion:
I'm back to classic for now 🙈 |
bjoluc
reviewed
Jan 6, 2025
bjoluc
approved these changes
Jan 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing
typeparameter returns unfriendly errors such asTypeError: Cannot read properties of undefined (reading 'info').Added a clearer error message with a check that the
typeparameter is provided and is associated with aninfoobject.Testing
npm test