feat: data-driven and random AnimatedLogo
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-collinsworth
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
This is really, really cool. Awesome work! I love it. @lucacasonato any issues with merging this?
by extracting the logo as an ASCII drawing, and mapping over the values, we get more control over the shape, colours, animation randomness and positioning of the internal elements. the asset is a snapshot of the rendered HTML on a given page. Manual adjustments of individual blocks is easier with inline styles.
unlike the logo on the home page which has two, this asset has a single block of blank space.
mxdvl
force-pushed
the
mxdvl/animated-logo
branch
from
ee24286 to
6d3f95f
Compare
mxdvl
commented
Apr 1, 2024
| xmlnsXlink="http://www.w3.org/1999/xlink" | ||
| xml:space="preserve" | ||
| style="fill-rule:evenodd;clip-rule:evenodd;stroke-linejoin:round;stroke-miterlimit:2;" | ||
| viewBox="-2 -2 17 11" |
There was a problem hiding this comment.
The actual drawing is 13 by 7, but accounting for a padding of 2 all around.
We could write this thusly with less magic numbers:
const padding = 2;
const width = 13;
const height = 7;
const viewBox = [
-padding,
-padding,
padding + width + padding,
padding + height + padding,
].join(' ');
|
Cool. I pushed a change that fixes a little glitch I saw where the server render and the client rendered random positions would not be in sync, causing a little jump of all the pixels immediately after page load (as soon as the logo re-rendered on the client). Fixed this by not re-rendering the logo on the client. Also updated the CSS to respect the |
lucacasonato
changed the title
AnimatedLogoAnimatedLogo
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
By extracting the logo as an ASCII drawing, and mapping over the values, we get more control
over the shape, colours, animation randomness and positioning of the internal elements.
What?
Iterate over the ASCII representation of the logo, transforming
█and░blocks into their respective colours and discarding spaces to generate the individual SVGrect.The SVG asset is a snapshot of the rendered HTML on a given page. Manual adjustments of individual blocks is easier with inline styles.