Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add latest field to package metadata #45

Merged
merged 2 commits into from
Feb 29, 2024
Merged

feat: add latest field to package metadata #45

merged 2 commits into from
Feb 29, 2024

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Feb 28, 2024 •
edited
Loading

ry
ry approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ry ry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think. Is there any danger that parsing existing PackageMetadata files could fail after this change?

lucacasonato
lucacasonato commented Feb 29, 2024
View reviewed changes
Copy link
Member Author

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The API doesn't parse PackageMetadata from the bucket, and the serde_json ignores unknown fields (so CLI won't break either because it does not deserialize this field).

@lucacasonato lucacasonato added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit db9fc94 Feb 29, 2024
5 checks passed
@lucacasonato lucacasonato deleted the pkg_metadata_latest branch February 29, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @ry