-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(logo): introduce logo variant #935
base: main
Are you sure you want to change the base?
Conversation
Are you refering to https://jsr.io/logo-square.svg 🤔 Note this also: mdn/content#37761 |
IMO having two different file is better. |
And look at Deno and node, which have different branding for light and dark |
The web has evolved beyond using separate icons and/or stylesheets...
|
Here is a version of https://jsr.io/logo-square.svg, with modifications that auto change colors upon changing light/dark mode 😉 <svg width="100%" height="100%" viewBox="0 -3 13 13" version="1.1" xmlns="http://www.w3.org/2000/svg">
<style>
:root {
color-scheme: light dark;
}
svg {
> path {
fill: light-dark(#f7df1e, #083344);
}
> g {
fill: light-dark(#083344, #f7df1e);
}
}
</style>
<path d="M0,2h2v-2h7v1h4v4h-2v2h-7v-1h-4"/>
<g>
<path d="M1,3h1v1h1v-3h1v4h-3"/>
<path d="M5,1h3v1h-2v1h2v3h-3v-1h2v-1h-2"/>
<path d="M9,2h3v2h-1v-1h-1v3h-1"/>
</g>
</svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't feel this version works better than the existing version; the colors both being light create more of a clash than the dark blue on a dark background, to my eye.
In any case, though: I'm not convinced a secondary version is needed currently. While the dark cyan of the existing logo admittedly has low contrast against a dark background, which isn't ideal, I don't think it's currently an issue, as the logo is still legible thanks to the yellow.
If dark mode is implemented on jsr.io, we can (and should) revisit this topic then, to holistically determine whether an alternate version is needed and how it might work best in that environment.
In the meantime, though—while I appreciate the effort that went into this and the forward-looking approach—in my opinion, this isn't something we should pursue right now, and we would probably want to explore other implementations when we do.
In case of dark theme for JSR we need a "inverted" logo to unsure good contrast ratio
The orignal logo use
jsr-cyan-950
and light onejsr-cyan-50