Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/f 230 Comparison Portal | Compare Country Regions #193

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

jschoedl
Copy link
Collaborator

@jschoedl jschoedl commented Jan 18, 2025

  • There are some uncaught errors if data is not defined, e.g. for Cambodia (currently fixing it)
  • For now, there are only absolute numbers displayed. The relative numbers are implemented and tested (see CountryComparisonAccordion, line 24), but it might be of use to add a switch in the charts toolbar instead of an additional chart.
  • The historic line chart does not really make sense if there are very many regions. We might discuss this later. Options to deal with this could be:
    • disabling it with e.g. >15 countries
    • showing aggregate numbers like min, max, mean, median (maybe together with greyish lines of the actual data in the "background")
    • show a warning, but let the user proceed to render the chart if requested

demo:

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for wfp-hungermap ready!

Name Link
🔨 Latest commit 96b3126
🔍 Latest deploy log https://app.netlify.com/sites/wfp-hungermap/deploys/678fa4f3a46bda0008cb6398
😎 Deploy Preview https://deploy-preview-193--wfp-hungermap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 16
Accessibility: 97
Best Practices: 0
SEO: 100
PWA: 90
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jschoedl jschoedl marked this pull request as draft January 18, 2025 17:36
@bohdangarchu

This comment was marked as resolved.

@bohdangarchu
Copy link
Collaborator

Also the selection component started triggering jumps to the top of the page again... This is a known nextUI issue and its a bit annoying
heroui-inc/heroui#3571

@jschoedl jschoedl removed the request for review from bohdangarchu January 20, 2025 07:01
@jschoedl
Copy link
Collaborator Author

jschoedl commented Jan 20, 2025

To-Do: no data available should be shown here. Need to check whether its an issue with our data processing or Categorical Chart
image

Fixed that! The data was null for some regions which was previously unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants