Change order of fallbacks for renderFileAsync #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation gives the impression that the fallback for a method follows a certain order. For renderFileAsync that order should then be * `.renderFileAsync` * `.renderFile` * `.renderAsync` * `.render` * `.compileFileAsync` * `.compileFile` * `.compileAsync` * `.compile` This commit makes the code follow that order
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 98.05% 98.04% -0.01%
==========================================
Files 1 1
Lines 206 205 -1
Branches 73 72 -1
==========================================
- Hits 202 201 -1
Misses 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be considered a question in the form of a PR. Sometimes just plain code conveys a question better. If the answer to my question is 'yes' than the PR can be merged.
The documentation gives the impression that the fallback for a method
follows a certain order. For renderFileAsync that order should then be
.renderFileAsync.renderFile.renderAsync.render.compileFileAsync.compileFile.compileAsync.compileThis commit makes the code follow that order.
Am I correct in assuming that the fallback should be in the order described in the documentation?