Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History is wrecked #2

Open
lol768 opened this issue Jun 30, 2019 · 2 comments
Open

History is wrecked #2

lol768 opened this issue Jun 30, 2019 · 2 comments

Comments

@lol768
Copy link

lol768 commented Jun 30, 2019

Can you use history.replaceState so the browser history doesn't get filled with spam after each keystroke in the editor? :)
@lol768
Copy link
Author

lol768 commented Jun 30, 2019 •
edited
Loading

urlpages/editor/editor.js

Line 118 in 5624164

window.location.hash = "#" + window.btoa(JSON.stringify(data)); 

history.replaceState({}, "", "/urlpages/editor/#" + window.btoa(JSON.stringify(data)));

@lodenrogue
Copy link

Great idea. Can you make a PR with that change?

lol768 pushed a commit to lol768/urlpages that referenced this issue Jun 30, 2019
Fix issue jstrieb#2
32e8587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lol768 @lodenrogue