Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ColorMaximum and ColorMinus property in NumericUpDown control #8

Merged
merged 4 commits into from
May 24, 2022
Merged

Added ColorMaximum and ColorMinus property in NumericUpDown control #8

merged 4 commits into from
May 24, 2022

Conversation

Sergtek
Copy link
Contributor

@Sergtek Sergtek commented May 23, 2022

NNy29yGmqD

Copy link
Owner

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. Suggested some small changes to improve it.

src/AlohaKit/Controls/NumericUpDown/NumericUpDown.cs Outdated Show resolved Hide resolved
@Sergtek
Copy link
Contributor Author

Sergtek commented May 24, 2022

In addition to resolving the comments, I have added two new properties: MinimumTextColor and MaximumTextColor to be able to also change the text color of the Minimum and Maximum.

@Sergtek Sergtek requested a review from jsuarezruiz May 24, 2022 11:28
@jsuarezruiz
Copy link
Owner

jsuarezruiz commented May 24, 2022

In addition to resolving the comments, I have added two new properties: MinimumTextColor and MaximumTextColor to be able to also change the text color of the Minimum and Maximum.

Thanks!

@jsuarezruiz jsuarezruiz merged commit 2a17127 into jsuarezruiz:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants