Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off label-has-for in strict rule set #734

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Aug 13, 2020

label-has-for has been deprecated and is already turned off in the recommended rule set.
Context: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md

Feel free to close this PR if it was intentional to leave label-has-for turned on in the strict rule set.

Closes #751.

`label-has-for` has been deprecated and is already turned off in the recommended rule set.
Context: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
@tarngerine
Copy link

could we merge this in? encountered this today! thanks!

@janmonschke
Copy link
Contributor Author

could we merge this in? encountered this today! thanks!

It would be great to merge this.

Maybe @ljharb could have a look? :)
(I'm mentioning you directly because you pointed to this PR in #752, sorry for the noise)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@ljharb ljharb merged commit 8637aa7 into jsx-eslint:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deprecated rule label-has-for is still enabled in the strict preset
3 participants