Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include eslint@9 in peerDependencies #994

Closed
wants to merge 1 commit into from

Conversation

yuheiy
Copy link

@yuheiy yuheiy commented Jun 22, 2024

v6.9.0 supports Flat Config, but an error occurs during installation because peerDependencies does not include eslint@9. This PR adds "^9" to peerDependencies.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/eslint@9.5.0 environment Transitive: filesystem, unsafe +13 4.37 MB eslintbot

View full report↗︎

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.03%. Comparing base (882bd4d) to head (c257e65).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files         107      107           
  Lines        1651     1651           
  Branches      581      581           
=======================================
  Hits         1635     1635           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuheiy yuheiy mentioned this pull request Jun 22, 2024
@ljharb
Copy link
Member

ljharb commented Jun 22, 2024

That's not sufficient to support eslint 9; see #978. Please leave this PR open, since I'll now have to repurpose it when eslint 9 support is actually possible.

In the meantime, simply do not yet upgrade to eslint 9, until all of your plugins support it explicitly.

@ljharb ljharb marked this pull request as draft June 22, 2024 02:57
@andreyevyk
Copy link

With the publication of the version v6.9.0, is it now possible to include eslint@9 in peerDependencies?

@ljharb
Copy link
Member

ljharb commented Aug 24, 2024

@andreyevyk nope, not yet, see #978.

@burtek
Copy link

burtek commented Sep 2, 2024

@ljharb what about now?

@michaelfaith
Copy link
Contributor

This is already covered by #1009

@burtek
Copy link

burtek commented Sep 2, 2024

@michaelfaith true 🤦 I think it's time for me to go to bed

@ljharb
Copy link
Member

ljharb commented Sep 2, 2024

Indeed; obsoleted by #1009.

@ljharb ljharb closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants