Fix forbid-prop-types crash (fixes #579)

jsx-eslint · May 8, 2016 · 6950cbd · 6950cbd
1 parent 504e0d0
commit 6950cbd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
@@ -53,6 +53,9 @@ module.exports = function(context) {
    */
   function checkForbidden(declarations) {
     declarations.forEach(function(declaration) {
+      if (declaration.type !== 'Property') {
+        return;
+      }
       var target;
       var value = declaration.value;
       if (

diff --git a/tests/lib/rules/forbid-prop-types.js b/tests/lib/rules/forbid-prop-types.js
@@ -188,6 +188,17 @@ ruleTester.run('forbid-prop-types', rule, {
       '});'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    // Proptypes declared with a spread property
+    code: [
+      'class Test extends react.component {',
+      '  static propTypes = {',
+      '    intl: React.propTypes.number,',
+      '    ...propTypes',
+      '  };',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }],
 
   invalid: [{