[Fix] no-unused-prop-types/TypeScript: avoid crash on indexable int…

…erface Fixes #2687.
jsx-eslint · Jun 30, 2020 · 830bde7 · taion · Jun 30, 2020 · ljharb
1 parent 2db0080
commit 830bde7
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/lib/util/propTypes.js b/lib/util/propTypes.js
@@ -314,12 +314,14 @@ module.exports = function propTypesInstructions(context, components, utils) {
     }
 
     foundDeclaredPropertiesList.forEach((tsPropertySignature) => {
-      declaredPropTypes[tsPropertySignature.key.name] = {
-        fullName: tsPropertySignature.key.name,
-        name: tsPropertySignature.key.name,
-        node: tsPropertySignature,
-        isRequired: !tsPropertySignature.optional
-      };
+      if (tsPropertySignature.type !== 'TSIndexSignature') {
+        declaredPropTypes[tsPropertySignature.key.name] = {
+          fullName: tsPropertySignature.key.name,
+          name: tsPropertySignature.key.name,
+          node: tsPropertySignature,
+          isRequired: !tsPropertySignature.optional
+        };
+      }
     });
     return false;
   }

diff --git a/tests/lib/rules/no-unused-prop-types.js b/tests/lib/rules/no-unused-prop-types.js
@@ -5555,6 +5555,23 @@ ruleTester.run('no-unused-prop-types', rule, {
         }
       ]
     },
+    {
+      code: [
+        'interface Foo {',
+        '  foo: string;',
+        '  [blah: string]: number;',
+        '}',
+        'const Hello = ({bar}: Foo) => {',
+        '    return <div>Hello {bar}</div>;',
+        '}'
+      ].join('\n'),
+      parser: parsers.TYPESCRIPT_ESLINT,
+      errors: [
+        {
+          message: '\'foo\' PropType is defined but prop is never used'
+        }
+      ]
+    },
     {
       code: [
         'const Hello = ({firstname}: {firstname: string, lastname: string}) => {',