Fix style-prop-object crash (fixes #834)

jsx-eslint · Sep 14, 2016 · a2a3de1 · a2a3de1
1 parent 6b58f21
commit a2a3de1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/rules/style-prop-object.js b/lib/rules/style-prop-object.js
@@ -62,7 +62,7 @@ module.exports = {
       },
 
       JSXAttribute: function(node) {
-        if (node.name.name !== 'style') {
+        if (!node.value || node.name.name !== 'style') {
           return;
         }
 

diff --git a/tests/lib/rules/style-prop-object.js b/tests/lib/rules/style-prop-object.js
@@ -102,6 +102,10 @@ ruleTester.run('style-prop-object', rule, {
         'React.createElement("div", { style: styles });'
       ].join('\n'),
       parserOptions: Object.assign({sourceType: 'module'}, parserOptions)
+    },
+    {
+      code: '<div style></div>',
+      parserOptions: parserOptions
     }
   ],
   invalid: [
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,7 +62,7 @@ module.exports = { @@
           },
           JSXAttribute: function(node) {
-            if (node.name.name !== 'style') {
+            if (!node.value || node.name.name !== 'style') {
               return;
             }
@@ Expand Down @@