Merge pull request #164 from mkenyon/no-unknown-event-handlers

Add event handlers to no-unknown-property
jsx-eslint · Jul 27, 2015 · b1a7b0c · b1a7b0c
2 parents 3556264 + 8704c65
commit b1a7b0c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/no-unknown-property.js b/lib/rules/no-unknown-property.js
@@ -22,7 +22,12 @@ var DOM_PROPERTY_NAMES = [
   'cellPadding', 'cellSpacing', 'charSet', 'classID', 'className', 'colSpan', 'contentEditable', 'contextMenu',
   'crossOrigin', 'dateTime', 'encType', 'formAction', 'formEncType', 'formMethod', 'formNoValidate', 'formTarget',
   'frameBorder', 'hrefLang', 'htmlFor', 'httpEquiv', 'marginHeight', 'marginWidth', 'maxLength', 'mediaGroup',
-  'noValidate', 'radioGroup', 'readOnly', 'rowSpan', 'spellCheck', 'srcDoc', 'srcSet', 'tabIndex', 'useMap',
+  'noValidate', 'onBlur', 'onChange', 'onClick', 'onContextMenu', 'onCopy', 'onCut', 'onDoubleClick',
+  'onDrag', 'onDragEnd', 'onDragEnter', 'onDragExit', 'onDragLeave', 'onDragOver', 'onDragStart', 'onDrop',
+  'onFocus', 'onInput', 'onKeyDown', 'onKeyPress', 'onKeyUp', 'onMouseDown', 'onMouseEnter', 'onMouseLeave',
+  'onMouseMove', 'onMouseOut', 'onMouseOver', 'onMouseUp', 'onPaste', 'onScroll', 'onSubmit', 'onTouchCancel',
+  'onTouchEnd', 'onTouchMove', 'onTouchStart', 'onWheel',
+  'radioGroup', 'readOnly', 'rowSpan', 'spellCheck', 'srcDoc', 'srcSet', 'tabIndex', 'useMap',
   'itemProp', 'itemScope', 'itemType', 'itemRef', 'itemID'
 ];
 

diff --git a/tests/lib/rules/no-unknown-property.js b/tests/lib/rules/no-unknown-property.js
@@ -45,6 +45,14 @@ eslintTester.addRuleTest('lib/rules/no-unknown-property', {
   }, {
     code: '<div accesskey="bar"></div>;',
     errors: [{message: 'Unknown property \'accesskey\' found, use \'accessKey\' instead'}],
+    ecmaFeatures: {jsx: true}
+  }, {
+    code: '<div onclick="bar"></div>;',
+    errors: [{message: 'Unknown property \'onclick\' found, use \'onClick\' instead'}],
+    ecmaFeatures: {jsx: true}
+  }, {
+    code: '<div onmousedown="bar"></div>;',
+    errors: [{message: 'Unknown property \'onmousedown\' found, use \'onMouseDown\' instead'}],
     ecmaFeatures: {jsx: true}}
   ]
 });