-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style-prop-object does not allow null #812
Comments
indeed, |
This might be worth looking into at the same time as #809 |
resolved (Fixes jsx-eslint#809) (Fixes jsx-eslint#812)
resolved (Fixes jsx-eslint#809) (Fixes jsx-eslint#812)
@ljharb This fails in let style = null;
<div style={style}></div> I dropped the unnecessary |
@vdh fails in what way? |
I was also able to get a test failure by duplicating this existing test and adding |
…ined` var style props. Per jsx-eslint#812 (comment)
@vdh thanks, this is now fixed in latest master. |
I use
style
variables that are conditionally set as objects only when required, and AFAIK it's valid to provide null props to React.The text was updated successfully, but these errors were encountered: