Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support --fix-type #2619

Closed
wants to merge 5 commits into from
Closed

Added support --fix-type #2619

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2020

  1. Add the type field in rule's meta
  2. Fix the fixable field

PR resolve #2618

@ljharb
Add support --fix-type
d11d55d 
1) Add the type field in rule's meta
2) Fix the fixable field
@ghost ghost changed the title Add support --fix-type Added support --fix-type Apr 8, 2020
@ghost
Copy link
Author

ghost commented Apr 8, 2020 •
edited by ghost
Loading

What do you think about the rules that sort something?
Сan they be attributed to the layout type?

ljharb
ljharb reviewed Apr 12, 2020
View reviewed changes
lib/rules/forbid-component-props.js Outdated Show resolved Hide resolved
lib/rules/forbid-dom-props.js Outdated Show resolved Hide resolved
lib/rules/forbid-elements.js Outdated Show resolved Hide resolved
lib/rules/jsx-child-element-spacing.js Outdated Show resolved Hide resolved
lib/rules/jsx-no-comment-textnodes.js Outdated Show resolved Hide resolved
lib/rules/no-typos.js Outdated Show resolved Hide resolved
lib/rules/sort-comp.js Show resolved Hide resolved
lib/rules/sort-prop-types.js Show resolved Hide resolved
lib/rules/static-property-placement.js Outdated Show resolved Hide resolved
lib/rules/void-dom-elements-no-children.js Outdated Show resolved Hide resolved
Vlad Esin and others added 4 commits April 17, 2020 01:40
@ljharb
Apply suggestions from code review
4d4eea9 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
@ljharb
Apply suggestions from code review
b97e028 
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Apply suggestions from code review
8adffb3
Update void-dom-elements-no-children.js
024755d
@ljharb
Copy link
Member

ljharb commented Apr 21, 2020

Seems like the final issue is the rules that exist to mark things as "used" - I'm pretty concerned that any fix-type usage without these rules enabled will break people's code.

@ljharb
Copy link
Member

ljharb commented Aug 9, 2021

Unfortunately this PR's author has deleted their account, so the PR can't be landed.

@ljharb ljharb closed this Aug 9, 2021
@ljharb ljharb mentioned this pull request Jan 4, 2022
Open
@sryze
Copy link

sryze commented Jan 4, 2022

Would it be OK if someone opened a new PR and just copied the changes from this one? It looks like we can still access the diff

@ljharb
Copy link
Member

ljharb commented Jan 4, 2022

@sryze normally no, but since this one is unrecoverable, sure. please keep the commit authorship, and also please make sure it's rebased :-)

@sryze sryze mentioned this pull request Jan 4, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autofix --fix-type layout
3 participants
@ljharb @sryze @golopot