-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] prefer-read-only-props
: Add TypeScript Support
#3593
[Fix] prefer-read-only-props
: Add TypeScript Support
#3593
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3593 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 132 132
Lines 9288 9295 +7
Branches 3391 3397 +6
=======================================
+ Hits 9067 9074 +7
Misses 221 221
|
7f084b1
to
9c5ac98
Compare
@HenryBrown0 Thank you so much for this! You're a legend! |
Just curious - what real life scenario does this protect against when using TypeScript? Props already come through as |
@greypants const is about reassignment; this is about mutation. |
Fixes #3535
Adds TypeScript support to
prefer-read-only-props
rule.