fix: revert single template literal expression which might be intended usage

[taozhou-glean]

This reverts #3538, while keeping the test case there for explanation and future breakage prevention.

The previous commit broke for intended type casting usage: #3607

Sorry for adding the change, did not think enough before making it, apparently this is definitely legit use case for casting other type to string, we might be able to keep this rule and limit it to string single template literal with typechecker, but just a bit overkill at this moment.

[codecov]

Codecov Report

Merging #3611 (9ea0010) into master (1a3a17a) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9ea0010 differs from pull request most recent head f818096. Consider uploading reports for the commit f818096 to get more accurate results

@@            Coverage Diff             @@
##           master    #3611      +/-   ##
==========================================
- Coverage   97.62%   97.62%   -0.01%     
==========================================
  Files         132      132              
  Lines        9295     9288       -7     
  Branches     3397     3394       -3     
==========================================
- Hits         9074     9067       -7     
  Misses        221      221              

Impacted Files	Coverage Δ
lib/rules/jsx-curly-brace-presence.js	98.04% <ø> (-0.07%)	⬇️

[ljharb]

This has nothing to do with TS; JS also can use propTypes or runtime type checks - it's precisely as critical a use case in JS as it is in TS.

Honest mistake, though - I missed this too when reviewing your initial PR.

[taozhou-glean]

This has nothing to do with TS; JS also can use propTypes or runtime type checks - it's precisely as critical a use case in JS as it is in TS.

Honest mistake, though - I missed this too when reviewing your initial PR.

right, updated the description.

[akx]

Thanks, I didn't have the bandwidth over the weekend to do this in #3608 👍

[lucapollani]

Will this fix be released soon?

[ljharb]

I'm sure it will.