-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSDoc type annotations #3731
Add JSDoc type annotations #3731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't just adding type annotations and a lot of the changes are potentially breaking.
I have addressed this in pull request #3732 and will proceed to close this one. I'll handle the areas requiring type changes separately. |
I would prefer to update this PR with those changes rather than abandoning it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i only went like 20% through, but this should help you refine the entire thing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3731 +/- ##
==========================================
+ Coverage 97.62% 97.64% +0.01%
==========================================
Files 134 134
Lines 9617 9662 +45
Branches 3488 3514 +26
==========================================
+ Hits 9389 9434 +45
Misses 228 228 ☔ View full report in Codecov by Sentry. |
380e32c
to
51d342b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR, and extract any changes that aren't about whitespace/parens, or adding/editing comments, to separate commits - and then all the "type annotations" changes can be in a single commit i can review separately. Thanks!
fe9ced2
to
6e0c30f
Compare
I have rebased and cleaned up the commits. Please check. |
d687e25
to
fbaf8e3
Compare
fbaf8e3
to
605b6af
Compare
I've gone ahead and updated this to remove all the breaking changes. The way to safely resolve TypeScript's inability to understand that an |
I have added type annotations and fixed associated type errors.